Skip to content

👷 do not rely on hardcoded list of DCs #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

👷 do not rely on hardcoded list of DCs #3973

wants to merge 3 commits into from
+268 −104

Conversation

@thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Nov 19, 2025 •
edited
Loading

Motivation

We want to avoid hardcoding the list of datacenter in the release process. This will remove the need for creating a PR for new DCs.

For this we need two things:

  • get rid of siteByDatacenter: For this we discover the list of DC and their corresponding site using ddtool.
  • get rid of monitorIdsByDatacenter: For this we're querying the logs API directly. Newly created DC might not have api or application key setup so we're skipping the monitors for thoses.
    Another benefit from this new strategy for monitoring DC deployments is that we're able to only account for the errors related to the version of the SDK currently being deployed. This makes the release more resilient to unrelated monitor alerts.

Changes

  • Refactor a bit to normalize usage of datacenter vs uploadPath and try to make things more clear
  • Added unit tests for deploy-prod-dc script.
  • removed siteByDatacenter in favor of a ddtool command
  • remove monitorIdsByDatacenter in favor of a logs API query

Todos

  • install ddtool on the CI (or find another way)
  • fix upload-source-maps test failing. for some reason the mock seems to initialize too late

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@thomas-lebeau thomas-lebeau mentioned this pull request Nov 19, 2025
Merged
4 tasks
Base automatically changed from thomas.lebeau/allow-undefined-api-key to main November 19, 2025 11:58
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/better-release-monitor-check branch from 108e473 to a7184af Compare November 21, 2025 06:34
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 21, 2025 •
edited
Loading

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.10 KiB 164.10 KiB 0 B 0.00% ✅
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00% ✅
Rum Recorder 19.50 KiB 19.50 KiB 0 B 0.00% ✅
Logs 55.91 KiB 55.91 KiB 0 B 0.00% ✅
Flagging 944 B 944 B 0 B 0.00% ✅
Rum Slim 121.37 KiB 121.37 KiB 0 B 0.00% ✅
Worker 23.63 KiB 23.63 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.005 +25.00%
RUM - add error 0.0153 0.0127 -16.99%
RUM - add timing 0.0027 0.0032 +18.52%
RUM - start view 0.003 0.0036 +20.00%
RUM - start/stop session replay recording 0.0006 0.0007 +16.67%
Logs - log message 0.0129 0.0152 +17.83%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.31 KiB 25.43 KiB +128 B
RUM - add action 94.50 KiB 51.25 KiB -43.26 KiB
RUM - add timing 24.07 KiB 23.81 KiB -274 B
RUM - add error 94.35 KiB 53.38 KiB -40.97 KiB
RUM - start/stop session replay recording 24.25 KiB 23.84 KiB -422 B
RUM - start view 430.18 KiB 425.44 KiB -4.74 KiB
Logs - log message 42.48 KiB 43.99 KiB +1.50 KiB

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 21, 2025 •
edited by datadog-official bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 92.67% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0f13224 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/better-release-monitor-check branch from f97fd57 to d547c0e Compare November 21, 2025 08:46
@thomas-lebeau thomas-lebeau changed the title 👷 replace monitor checks by logs query 👷 rdo not rely on hardcoded list of DCs Nov 21, 2025
@thomas-lebeau thomas-lebeau changed the title 👷 rdo not rely on hardcoded list of DCs 👷 do not rely on hardcoded list of DCs Nov 21, 2025
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/better-release-monitor-check branch from 5dde1dc to 0f13224 Compare November 21, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomas-lebeau